Page MenuHomePhabricator

[dagster core] rm output join step
ClosedPublic

Authored by alangenfeld on Jul 22 2019, 6:55 PM.

Details

Reviewers
schrockn
Group Reviewers
Restricted Project
Commits
R1:409dd661eb7d: [dagster core] rm output join step
Summary

remove the joining execution step and add a StepInputSourceType to distinguish multi-dep, single-dep, and config based inputs.

Test Plan

existing tests

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Jul 22 2019, 6:55 PM
alangenfeld retitled this revision from rm output join step to [dagster core] rm output join step.Jul 22 2019, 6:56 PM
alangenfeld edited the summary of this revision. (Show Details)Jul 22 2019, 8:13 PM
alangenfeld added a reviewer: Restricted Project.
schrockn accepted this revision.Jul 25 2019, 5:41 PM
schrockn added a subscriber: schrockn.

nicely done

python_modules/dagster/dagster/core/execution/plan/objects.py
101–102

We should cull the enums in StepKind. I think a lot of these are unused now

This revision is now accepted and ready to land.Jul 25 2019, 5:41 PM
alangenfeld updated this revision to Diff 3210.Jul 25 2019, 9:28 PM

additional cleanup

alangenfeld updated this revision to Diff 3211.Jul 25 2019, 9:31 PM

further clean up

Harbormaster failed remote builds in B2574: Diff 3211!
This revision was automatically updated to reflect the committed changes.