hey sorry for the delay on this - seems pretty good to me. Added @johann since hes done plenty of helm changes so would be curious for his take
some inline ? on misc changes that are not clear to me why they are in this diff
|1 ↗||(On Diff #32716)|
Since we are now using the kubernetes objects to model the values in the tests, this override is required so that we can construct the object from a dictionary. We take this approach since we defer to the json schema to determine what fields are available to this object.