Page MenuHomeElementl

Fully qualify all image names
ClosedPublic

Authored by max on Feb 26 2021, 7:47 PM.

Details

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 26 2021, 9:20 PM
Harbormaster failed remote builds in B26556: Diff 32445!
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 27 2021, 1:46 AM
Harbormaster failed remote builds in B26576: Diff 32470!
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 27 2021, 3:29 AM
Harbormaster failed remote builds in B26585: Diff 32485!
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 1 2021, 5:16 PM
Harbormaster failed remote builds in B26617: Diff 32523!
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 1 2021, 5:59 PM
Harbormaster failed remote builds in B26619: Diff 32525!
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 1 2021, 6:28 PM
Harbormaster failed remote builds in B26620: Diff 32527!
max requested review of this revision.Mar 1 2021, 6:49 PM
helm/dagster/templates/deployment-dagit.yaml
49

use template

helm/dagster/values.yaml
773โ€“776

add to helm schema?

looks good to me, defer to @rexledesma's feedback about schema + template

will resign for queue management

helm/dagster/templates/deployment-dagit.yaml
49

ok

helm/dagster/values.yaml
773โ€“776

ok

This revision is now accepted and ready to land.Mar 3 2021, 9:15 PM
This revision was landed with ongoing or failed builds.Mar 3 2021, 11:29 PM
Closed by commit R1:75746e0d8af8: Fully qualify all image names (authored by max). ยท Explain Why
This revision was automatically updated to reflect the committed changes.