Page MenuHomeElementl

Add support for pushing built images to ECR
ClosedPublic

Authored by max on Feb 26 2021, 7:43 PM.

Details

Summary

Going forward we will push built images to ECR as well as DockerHub as part of our release process.

Test Plan

Manual

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

max requested review of this revision.Feb 26 2021, 8:03 PM
python_modules/automation/automation/docker/cli.py
151โ€“152

Would prefer the explicit forward slash here, rather than in the prefix

156

this is the same as push_dockerhub but with different tags - can we refactor the shared logic

after rex's comments, looks good to me. going to resign so it's out of my queue

python_modules/automation/automation/docker/cli.py
151โ€“152

ok

156

sure, i think it's less clear when factored

This revision is now accepted and ready to land.Mar 3 2021, 8:45 PM
This revision was automatically updated to reflect the committed changes.