Page MenuHomeElementl
Differential D6671

Fully qualify all images
AbandonedPublic
Actions

Authored by max on Feb 25 2021, 6:51 PM.

Details

Reviewers
rexledesma
catherinewu
johann
Summary

Partial resolution of https://github.com/dagster-io/dagster/issues/3584

Test Plan

Integration

Diff Detail

Repository
R1 dagster
Branch
template-helm-registry
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

max created this revision.Feb 25 2021, 6:51 PM
Harbormaster completed remote builds in B26446: Diff 32314.Feb 25 2021, 7:09 PM
max requested review of this revision.Feb 25 2021, 7:09 PM
max updated this revision to Diff 32319.Feb 25 2021, 7:28 PM

Qualify all images with registry

max retitled this revision from Allow the busybox image to be overridden to Fully qualify all images.Feb 25 2021, 7:29 PM
Harbormaster failed remote builds in B26450: Diff 32319!Feb 25 2021, 7:51 PM
rexledesma requested changes to this revision.Feb 25 2021, 7:59 PM

can we add this to the helm schema as well, and use dagster-helm schema --command apply

helm/dagster/templates/helpers/_helpers.tpl
28–30

this needs to be edited as well

This revision now requires changes to proceed.Feb 25 2021, 7:59 PM
max updated this revision to Diff 32342.Feb 25 2021, 9:51 PM

fixup image.name

max marked an inline comment as done.Feb 25 2021, 10:02 PM
Harbormaster failed remote builds in B26463: Diff 32342!Feb 25 2021, 10:13 PM
max abandoned this revision.Feb 25 2021, 10:14 PM

Revision Contents
Changeset List

Diff 32342

View Options

helm/dagster/templates/deployment-celery-queues.yaml

Loading...
View Options

helm/dagster/templates/deployment-daemon.yaml

Loading...
View Options

helm/dagster/templates/deployment-dagit.yaml

Loading...
View Options

helm/dagster/templates/deployment-flower.yaml

Loading...
View Options

helm/dagster/templates/deployment-user.yaml

Loading...
View Options

helm/dagster/templates/helpers/_helpers.tpl

Loading...
View Options

helm/dagster/templates/tests/test-connection.yaml

Loading...
View Options

helm/dagster/values.yaml

Loading...