Page MenuHomeElementl

fix redis condition in helm requirements.yaml
ClosedPublic

Authored by catherinewu on Feb 25 2021, 5:58 AM.

Details

Summary

User feedback:
"It appears that you cannot have a negation in a condition in requirements.yaml dependencies and so the redis pods appear to always get started up regardless of whether redis.external==true.
Furthermore, listing a series of comma separated conditions appears to greedily decide based on the first non-undefined value in the list.
https://github.com/helm/helm/issues/4960"

Test Plan

integration

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Manual test 1:

redis:
  # To use redis instead of rabbitmq, set `enabled` to true.
  enabled: true

  # To manage redis via helm, set `internal` to `true`. To use an external redis, set `internal` to `false`.
  # Note: If `internal` is true, then redis pod will be created regardless of `enabled` flag.
  internal: true

Screen Shot 2021-02-24 at 10.01.35 PM.png (538×3 px, 592 KB)

Manual test 2:

redis:
  # To use redis instead of rabbitmq, set `enabled` to true.
  enabled: true

  # To manage redis via helm, set `internal` to `true`. To use an external redis, set `internal` to `false`.
  # Note: If `internal` is true, then redis pod will be created regardless of `enabled` flag.
  internal: false

Screen Shot 2021-02-24 at 10.02.27 PM.png (554×3 px, 574 KB)

This revision is now accepted and ready to land.Feb 25 2021, 5:05 PM