Page MenuHomePhabricator

Update contributing guide (#1583)
ClosedPublic

Authored by natekupp on Jul 19 2019, 6:38 PM.

Details

Reviewers
schrockn
Group Reviewers
Restricted Project
Commits
R1:50385acd935b: Update contributing guide (#1583)
Test Plan

docs only

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

natekupp created this revision.Jul 19 2019, 6:38 PM
natekupp added a reviewer: Restricted Project.Jul 19 2019, 6:39 PM
schrockn accepted this revision.Jul 19 2019, 6:48 PM
schrockn added a subscriber: schrockn.
schrockn added inline comments.
docs/sections/community/contributing.rst
16–19

recommend 3.7?

105

:-/ looking forward to a docs project

This revision is now accepted and ready to land.Jul 19 2019, 6:48 PM
natekupp updated this revision to Diff 3059.Jul 19 2019, 7:03 PM

comments

max added a subscriber: max.Jul 19 2019, 7:06 PM
max added inline comments.
docs/sections/community/contributing.rst
87–88

do any of us actually do this?

natekupp added inline comments.Jul 19 2019, 7:10 PM
docs/sections/community/contributing.rst
87–88

I don't :)

This revision was landed with ongoing or failed builds.Jul 19 2019, 7:14 PM
This revision was automatically updated to reflect the committed changes.