Page MenuHomeElementl

[dagit] Enable react/jsx-no-target-blank
ClosedPublic

Authored by dish on Feb 23 2021, 4:31 PM.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish requested review of this revision.Feb 23 2021, 4:39 PM

Reading up on the lint rule a bit, it appears that noreferrer implies noopener, so the rule now just requires noreferrer.

Just curious, why do we want noreferrer on some of these links, especially docs links? Seems like it would be helpful for analytics.

This revision is now accepted and ready to land.Feb 23 2021, 4:54 PM

My thinking is:

  • It's good practice for us to be in the habit of noreferrer for external links we don't control
  • For users who click through to docs/etc from their own internal Dagit instances, it seems best to avoid referrers
This revision was automatically updated to reflect the committed changes.