[easy] No logspew in Repository Location Handle cleanup
ClosedPublic
Actions

Authored by dgibson on Feb 22 2021, 4:58 PM.

Details

Reviewers

sashank
alangenfeld

Commits

R1:b2cbc93157c4: [easy] No logspew in Repository Location Handle cleanup

Summary

This can happen if you CTRL-C while a handle is spinning up and the constructor is interrupted - the destructor checks for these fields and throws because they haven't been set yet.

Test Plan

BK, interrupt a dagster-daemon process, no spew

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dgibson created this revision.Feb 22 2021, 4:58 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 22 2021, 5:14 PM

Harbormaster failed remote builds in B26266: Diff 32086!

Harbormaster completed remote builds in B26280: Diff 32107.Feb 22 2021, 8:09 PM

dgibson requested review of this revision.Feb 22 2021, 8:09 PM

sashank accepted this revision.Feb 22 2021, 8:38 PM

This revision is now accepted and ready to land.Feb 22 2021, 8:38 PM

Closed by commit R1:b2cbc93157c4: [easy] No logspew in Repository Location Handle cleanup (authored by dgibson). · Explain WhyFeb 22 2021, 9:04 PM

This revision was automatically updated to reflect the committed changes.

dgibson added a commit: R1:b2cbc93157c4: [easy] No logspew in Repository Location Handle cleanup.

Revision Contents
Changeset List

Path

Size

python_modules/

dagster/

core/

host_representation/

handle.py

2 lines

Diff 32119

View Options

python_modules/dagster/dagster/core/host_representation/handle.py

[easy] No logspew in Repository Location Handle cleanupClosedPublicActions