Page MenuHomeElementl

[dagit] Fix Asset search selection
ClosedPublic

Authored by dish on Feb 19 2021, 4:03 PM.

Details

Summary

Resolves #3714

Repair asset search typeahead selection behavior.

  • Fix using keyboard to choose items when a querystring is in use
  • Allow cycling through results with keys
  • Fix resetting highlight and dropdown visibility when text changes
Test Plan

View Asset search, verify that I can choose the correct items with mouse and keyboard, whether or not a querystring is in use.

Type a character, press escape to hide dropdown. Type something else, verify that it reappears.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish requested review of this revision.Feb 19 2021, 4:09 PM
This revision is now accepted and ready to land.Feb 22 2021, 7:49 PM
This revision was automatically updated to reflect the committed changes.