Page MenuHomeElementl

[dagit] Fix RunDetails timing strings
ClosedPublic

Authored by dish on Feb 19 2021, 3:26 PM.

Details

Summary

Resolves #3689

Repair the started/ended/duration strings in the Run details header. Included a test to validate, please advise if any of the scenarios are incorrect.

Test Plan

yarn jest RunDetails

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

js_modules/dagit/src/runs/RunDetails.tsx
34

My understanding is that some of these (e.g. SUCCESS) should never really happen, since both endTime and startTime should be present on the stats, and would thus not fall through to this switch.

dish requested review of this revision.Feb 19 2021, 3:34 PM
This revision is now accepted and ready to land.Feb 19 2021, 5:06 PM
This revision was automatically updated to reflect the committed changes.