Page MenuHomeElementl
Differential D6603

[dagit] Fix RunDetails timing strings
ClosedPublic
Actions

Authored by dish on Feb 19 2021, 3:26 PM.

Details

Reviewers
johann
prha
dgibson
Commits
R1:59472fefb6f2: [dagit] Fix RunDetails timing strings
Summary

Resolves #3689

Repair the started/ended/duration strings in the Run details header. Included a test to validate, please advise if any of the scenarios are incorrect.

Test Plan

yarn jest RunDetails

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish created this revision.Feb 19 2021, 3:26 PM
dish added inline comments.Feb 19 2021, 3:27 PM
js_modules/dagit/src/runs/RunDetails.tsx
34

My understanding is that some of these (e.g. SUCCESS) should never really happen, since both endTime and startTime should be present on the stats, and would thus not fall through to this switch.

Harbormaster completed remote builds in B26198: Diff 32006.Feb 19 2021, 3:34 PM
dish requested review of this revision.Feb 19 2021, 3:34 PM
prha accepted this revision.Feb 19 2021, 5:06 PM
This revision is now accepted and ready to land.Feb 19 2021, 5:06 PM
Closed by commit R1:59472fefb6f2: [dagit] Fix RunDetails timing strings (authored by dish). · Explain WhyFeb 19 2021, 6:26 PM
This revision was automatically updated to reflect the committed changes.
dish added a commit: R1:59472fefb6f2: [dagit] Fix RunDetails timing strings.

Revision Contents
Changeset List

PathSize
js_modules/
dagit/
src/
runs/
253 lines
15 lines
types/

Diff 32030

View Options

js_modules/dagit/src/runs/RunDetails.test.tsx

Loading...
View Options

js_modules/dagit/src/runs/RunDetails.tsx

Loading...
View Options

js_modules/dagit/src/runs/types/RunDetailsTestQuery.ts

Loading...