Page MenuHomeElementl

Use correct command for liveness-check
ClosedPublic

Authored by johann on Feb 18 2021, 5:41 PM.

Details

Summary

Fix https://dagster.phacility.com/D6212, which added the new all_daemons_live function but didn't change the cli call.

"daemon alive": recent heartbeat
"daemon healthy": daemon alive and without error

Test Plan

Integration

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

johann added a reviewer: dgibson.
johann edited the test plan for this revision. (Show Details)

I see how this is hard to test particularly in a way that would differentiate it from the health check, but is there any test that might have caught the issue here?

python_modules/dagster/dagster/daemon/cli/__init__.py
79–80

would be really nice to know which daemons aren't running when this happens

This revision is now accepted and ready to land.Feb 18 2021, 6:15 PM

There's an existing test that differentiates the all_daemons_healthy and all_daemons_live functions, but it doesn't actually invoke the cli. I guess it's time to bring the cli under test?

This revision was automatically updated to reflect the committed changes.