Page MenuHomeElementl

[dagit] Flip hideNonMatches default

Authored by dish on Feb 18 2021, 3:38 PM.



Relates to #3688.

In the Run log viewer, hideNonMatches currently defaults to false, so non-matching rows will appear in context alongside filter-matching rows.

I'm going to flip this default to true instead, as it seems like it might be a point of confusion that filtering doesn't always clearly surface results.

The UI is otherwise unchanged.

Test Plan

View Run, do some filtering. Verify that the "Hide non-matches" box is unchecked by default. Check it, verify that non-matching logs are shown and that the URL updates accordingly.

Diff Detail

R1 dagster
Lint Not Applicable
Tests Not Applicable

Event Timeline

dish requested review of this revision.Feb 18 2021, 3:56 PM
This revision is now accepted and ready to land.Feb 22 2021, 7:48 PM
This revision was automatically updated to reflect the committed changes.