This diff adds an example of how to write pipelines to include a user in the loop.
The documentation is added.
The description for some examples has a period at the end, others hasn't. To be consistent, I also modified those description.
Details
Details
See tests
Diff Detail
Diff Detail
- Repository
- R1 dagster
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| examples/user_in_loop/tests/test_user_in_loop_pipeline.py | ||
|---|---|---|
| 26 | One thing I'm not sure here is if this is a good way to create a temporary file for testing. I do have another command at the bottom (line 60) to remove it after the test. | |
| examples/user_in_loop/tests/test_user_in_loop_pipeline.py | ||
|---|---|---|
| 26 | ||
| examples/user_in_loop/tests/test_user_in_loop_pipeline.py | ||
|---|---|---|
| 26 | Or is it better to use a tempfile module ? | |
| examples/user_in_loop/tests/test_user_in_loop_pipeline.py | ||
|---|---|---|
| 26 | Cool! thanks! | |
| examples/user_in_loop/tests/test_user_in_loop_pipeline.py | ||
|---|---|---|
| 26 | yes you should use tempfile | |
| 38 | better to have descriptive names here | |
| examples/user_in_loop/user_in_loop/repo.py | ||
| 38 | i think we should simplify this pipeline down to be a single solid. among other things, nothing actually blocks on wait_for_user_approval | |
| examples/user_in_loop/user_in_loop/repo.py | ||
|---|---|---|
| 33 | this should be much faster since it's going to be tested | |
| examples/user_in_loop/tests/test_user_in_loop_pipeline.py | ||
|---|---|---|
| 27 | if you do things this way, you're assuming that touch is available on the user's computer (this isn't true, e.g., on windows). instead: with open(file_path, 'r') as fd:
fd.write('ok')(or use dagster.utils.touch_file) | |
| examples/user_in_loop/user_in_loop/repo.py | ||
| 12 | we can drop the business logic completely (what is a price list? what is this price list? what does it have to do with anything) -- just leave a log line at the end of the solid | |
| examples/user_in_loop/tests/test_user_in_loop_pipeline.py | ||
|---|---|---|
| 27 | Gotta. Didn't recall the way of create a file using writing a file 😮will update it! | |
Comment Actions
Simplify the solid and docs completely. Use open file rather than subprocess to create a file.