Page MenuHomeElementl

Run complex_grpc_cycle tests in their own processs
AcceptedPublic

Authored by sashank on Feb 15 2021, 11:26 PM.

Details

Reviewers
dgibson
Summary

I believe these tests are timing out in BK because the threads are not getting enough time to run due to GIL contention within pytest. This diff updates the complex grpc cycle test to run within its own process with its own GIL so that it can run quickly and independently.

Test Plan

bk

Diff Detail

Repository
R1 dagster
Branch
use-multiproc
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

one more flake test against bk

remove loop for flake testing

I buy it - does pytest have any built-in support for this kind of thing?

python_modules/dagster/dagster_tests/general_tests/grpc_tests/test_watch_server.py
165

add a timeout?

166

seems fine, but is this different in practice than the exit code on the process being 0?

This revision is now accepted and ready to land.Feb 16 2021, 3:22 PM