Page MenuHomeElementl

Pass in WorkspaceLoadTarget to workspace rather than a list of origins
ClosedPublic

Authored by dgibson on Feb 15 2021, 9:02 PM.

Details

Summary

This is a refactor to enable a 'reloadWorkspace' API that reloads the list of repository locations in the workspace, not just an individual repository location.

Test Plan

Integration

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 15 2021, 9:24 PM
Harbormaster failed remote builds in B25834: Diff 31536!
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 15 2021, 9:55 PM
Harbormaster failed remote builds in B25840: Diff 31542!
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 15 2021, 10:13 PM
Harbormaster failed remote builds in B25841: Diff 31543!

believe tests are failing in master

python_modules/dagster-graphql/dagster_graphql/test/utils.py
52–66

these (and other in-process graphql suites) had to go for this to work, but that's not really a thing anymore for our users anyway

This is great! Being able to reload a workspace will be so useful

python_modules/dagster/dagster_tests/cli_tests/workspace_tests/multi_location/test_multi_location_workspace.py
276

Did not know about this, neat

This revision is now accepted and ready to land.Feb 16 2021, 4:46 PM
python_modules/dagster-graphql/dagster_graphql/test/utils.py
52–66

+1