Page MenuHomeElementl
Differential D6497

Pass in WorkspaceLoadTarget to workspace rather than a list of origins
ClosedPublic
Actions

Authored by dgibson on Feb 15 2021, 9:02 PM.

Details

Reviewers
sashank
alangenfeld
johann
max
Commits
R1:78c2654125dc: Pass in WorkspaceLoadTarget to workspace rather than a list of origins
Summary

This is a refactor to enable a 'reloadWorkspace' API that reloads the list of repository locations in the workspace, not just an individual repository location.

Test Plan

Integration

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dgibson created this revision.Feb 15 2021, 9:02 PM
dgibson updated this revision to Diff 31536.Feb 15 2021, 9:07 PM

up

Harbormaster failed remote builds in B25833: Diff 31534!Feb 15 2021, 9:18 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 15 2021, 9:24 PM
Harbormaster failed remote builds in B25834: Diff 31536!
dgibson updated this revision to Diff 31542.Feb 15 2021, 9:38 PM

up

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 15 2021, 9:55 PM
Harbormaster failed remote builds in B25840: Diff 31542!
dgibson updated this revision to Diff 31543.Feb 15 2021, 9:55 PM

up

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 15 2021, 10:13 PM
Harbormaster failed remote builds in B25841: Diff 31543!
dgibson requested review of this revision.Feb 15 2021, 10:23 PM

believe tests are failing in master

dgibson updated this revision to Diff 31546.Feb 15 2021, 10:26 PM

rebase on top of fix

Harbormaster completed remote builds in B25844: Diff 31546.Feb 15 2021, 10:59 PM
dgibson added inline comments.Feb 16 2021, 3:33 PM
python_modules/dagster-graphql/dagster_graphql/test/utils.py
52–66

these (and other in-process graphql suites) had to go for this to work, but that's not really a thing anymore for our users anyway

sashank accepted this revision.Feb 16 2021, 4:46 PM

This is great! Being able to reload a workspace will be so useful

python_modules/dagster/dagster_tests/cli_tests/workspace_tests/multi_location/test_multi_location_workspace.py
276

Did not know about this, neat

This revision is now accepted and ready to land.Feb 16 2021, 4:46 PM
sashank added inline comments.Feb 16 2021, 4:46 PM
python_modules/dagster-graphql/dagster_graphql/test/utils.py
52–66

+1

Closed by commit R1:78c2654125dc: Pass in WorkspaceLoadTarget to workspace rather than a list of origins (authored by dgibson). · Explain WhyFeb 16 2021, 4:53 PM
This revision was automatically updated to reflect the committed changes.
dgibson added a commit: R1:78c2654125dc: Pass in WorkspaceLoadTarget to workspace rather than a list of origins.

Revision Contents
Changeset List

PathSize
.buildkite/
dagster-buildkite/
dagster_buildkite/
steps/
3 lines
python_modules/
dagit/
dagit/
2 lines
dagster-graphql/
dagster_graphql/
test/
39 lines
dagster_graphql_tests/
graphql/
18 lines
182 lines
9 lines
6 lines
snapshots/
20 lines
4 lines
3 lines
12 lines
22 lines
26 lines
4 lines
1 line
4 lines
3 lines
dagster/
dagster/
cli/
workspace/
24 lines
15 lines
15 lines
dagster_tests/
cli_tests/
workspace_tests/
multi_location/
38 lines
81 lines

Diff 31579

View Options

.buildkite/dagster-buildkite/dagster_buildkite/steps/dagster.py

Loading...
View Options

python_modules/dagit/dagit/debug.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql/test/utils.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/conftest.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/graphql_context_test_suite.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/multi_location.yaml

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/setup.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_assets.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_composites.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_assets.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_compute_logs.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_graphql_context_test_suite.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_instance.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_reload_repository_location.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_retry_execution.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_run_launcher.py

Loading...
View Options

python_modules/dagster-graphql/pytest.ini

Loading...
View Options

python_modules/dagster-graphql/tox.ini

Loading...
View Options

python_modules/dagster-graphql/tox_postgres.ini

Loading...
View Options

python_modules/dagster/dagster/cli/workspace/cli_target.py

Loading...
View Options

python_modules/dagster/dagster/cli/workspace/load.py

Loading...
View Options

python_modules/dagster/dagster/cli/workspace/workspace.py

Loading...
View Options

python_modules/dagster/dagster_tests/cli_tests/workspace_tests/multi_location/test_multi_location_workspace.py

Loading...
View Options

python_modules/dagster/dagster_tests/cli_tests/workspace_tests/test_grpc_server_workspace.py

Loading...