Page MenuHomeElementl

Upgrade to Helm 3
ClosedPublic

Authored by rexledesma on Feb 15 2021, 8:48 PM.

Details

Summary

We do a couple of things here:

  • Consolidate requirements.yaml into Chart.yaml
  • Remove *.tgz files from the Helm directory

Since we already use JSON schema (https://helm.sh/docs/faq/#validating-chart-values-with-jsonschema), we're already using Helm 3. Here,
we follow another guideline of removing requirements.yaml in favor of Chart.yaml (https://helm.sh/docs/faq/#consolidation-of-requirementsyaml-into-chartyaml).

*.tgz files shouldn't be checked in here. When packaging or installing the repository from source, the --dependency-update should be used.

Test Plan

integration

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 15 2021, 9:05 PM
Harbormaster failed remote builds in B25831: Diff 31532!
rexledesma retitled this revision from Consolidate Helm requirements.yaml into Chart.yaml to Cleanup Helm directory.Feb 15 2021, 9:27 PM
rexledesma edited the summary of this revision. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 15 2021, 9:48 PM
Harbormaster failed remote builds in B25837: Diff 31539!

Macro pooh_eating_honey:

helm/dagster/Chart.yaml
16

small note: i recently changed this to condition: redis.enabled, not redis.external

This revision is now accepted and ready to land.Feb 17 2021, 7:07 PM
rexledesma retitled this revision from Cleanup Helm directory to Upgrade to Helm 3.Mar 3 2021, 10:07 PM
This revision was landed with ongoing or failed builds.Mar 3 2021, 10:07 PM
Closed by commit R1:4bb295a8fd5f: Upgrade to Helm 3 (authored by rexledesma). · Explain Why
This revision was automatically updated to reflect the committed changes.