Page MenuHomeElementl

[Easy] Missed run coordinator -> run worker switches
ClosedPublic

Authored by johann on Feb 13 2021, 12:46 AM.

Details

Summary

I missed a few spots where we still use run coordinator to the process that traverses the execution plan, now known as the run worker.

After this, I believe the only remaining usage is in k8s spec where we use component=run-worker. That's a (unlikely) potentially breaking change if any users have been filtering on the component name, so I'll get some feedback before making that change.

Test Plan

existing

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

johann added reviewers: dgibson, bob.
johann retitled this revision from Missed run coordinator -> run worker switches to [Easy] Missed run coordinator -> run worker switches.
dgibson added inline comments.
docs/next/src/pages/overview/pipeline-runs/executor.mdx
6

Is the term 'run worker' defined elsewhere in the docs that we could link to? Should we say "the process for the run" or something?

python_modules/libraries/dagster-celery-k8s/dagster_celery_k8s/launcher.py
274

Drop the underscore? "run worker job"

python_modules/libraries/dagster-k8s/dagster_k8s/launcher.py
305

^^

This revision is now accepted and ready to land.Feb 15 2021, 3:12 PM