Page MenuHomeElementl

Add parameter in Helm chart to set whether redis is created within k8s
ClosedPublic

Authored by catherinewu on Feb 12 2021, 11:47 PM.

Details

Summary

Add parameter in Helm chart to set whether redis is created w/in k8s

Without this option, users who want to use an external redis are forced to run an un-used redis pod in k8s

Test Plan

integration

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

catherinewu retitled this revision from Add parameter in Helm chart to set whether redis is created w/in k8s to Add parameter in Helm chart to set whether redis is created within k8s.Feb 15 2021, 5:59 PM
catherinewu edited the summary of this revision. (Show Details)
catherinewu added reviewers: rexledesma, nate.

I think this is fine for now - doesn't need to be in this diff, but should we deprecate these enabled flags and change the helm schema to be like

queue:
  type: redis ## or rabbitmq
  redisConfig: ...

similar to what @rexledesma has done elsewhere?

This revision is now accepted and ready to land.Feb 15 2021, 10:53 PM