Page MenuHomeElementl

Scaffold workspace when creating new dagster repo
ClosedPublic

Authored by rexledesma on Feb 12 2021, 12:29 AM.

Details

Summary

As the title.

Test Plan

local

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bob requested changes to this revision.Feb 15 2021, 5:52 PM
  • I originally left out the workspace.yaml for simplicity's sake. What are you thoughts on why to add the workspace.yaml?
  • In the case that we keep the workspace.yaml, it'd be good to update the README to add a description in the Contents table and have instructions on how use the workspace.yaml.
This revision now requires changes to proceed.Feb 15 2021, 5:52 PM

@bob I think being able to just run dagit instead of dagit -m PACKAGE.repository would be nice for ergonomics (since the workspace file is automatically discovered). We already surface the fact that we are using -m to load user code. The workspace.yaml is just the de-facto place for all of these concerns, so I don't think it will add more complexity.

I agree, we should have a workspace.yaml. Users will need to add one anyway very soon after getting started.

This revision is now accepted and ready to land.Feb 17 2021, 4:38 PM
rexledesma retitled this revision from Add repository import statement in "dagster new-repo" to Scaffold workspace when creating new dagster repo.Feb 17 2021, 5:37 PM
rexledesma edited the summary of this revision. (Show Details)