Page MenuHomeElementl

[dagit] Shortcut handlers for simple left nav
ClosedPublic

Authored by dish on Feb 11 2021, 10:06 PM.

Details

Summary

Add keyboard shortcuts for simple left nav. Not necessarily permanent while these are still in development -- we can discuss what the shortcut keys should be.

Test Plan

Toggle nav on, verify that keyboard shortcuts work for navigation.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish requested review of this revision.Feb 11 2021, 10:12 PM

This looks great! I like the new shortcut annotation styling too, matches the new sidebar a bit better ๐Ÿ‘

js_modules/dagit/src/nav/LeftNavSimple.tsx
34

Oh nice I hadn't seen this getModifierState API, I guess this is preferable to the old event.altKey, event.ctrlKey, event.metaKey? Reading up on it now and I don't quite see why they replaced those but there do seem to be more options with this API!

This revision is now accepted and ready to land.Feb 15 2021, 4:42 PM
js_modules/dagit/src/nav/LeftNavSimple.tsx
34

Yeah, I think it's to add more flexibility for the variety of modifiers. It's a bit annoying and verbose, but it works.

This revision was automatically updated to reflect the committed changes.