Page MenuHomeElementl

Move ProcessContext and RequestContext from dagster_graphql => dagster, add Workspace prefix

Authored by dgibson on Feb 9 2021, 8:42 PM.



These classes no longer really have much to do with graphql, and I'd like to use RequestContext in an internal repo without needing to include all of dagster-graphql.

Test Plan


Diff Detail

R1 dagster
Lint Not Applicable
Tests Not Applicable

Event Timeline

Everything here looks good. Thanks for cleaning up the unused context arguments.

Only question I have here is naming. Why WorkspaceProcessContext, as opposed to RepositoryLocationContext? I don't have any strong opinions, just wondering about what would be the most descriptive/accurate here. While both classes do have a back reference to the workspace/workspace snapshot, most of the methods on the request context have to do with repository locations.

This revision is now accepted and ready to land.Feb 9 2021, 10:24 PM

I also do not have a strong opinion on the name. My thinking was that a workspace is the term of a collection of repository locations - even when you specify only a single file, we still create a workspace for that file.