Page MenuHomeElementl

Modified schema, added BK checks, & added listen/notify skeleton
AbandonedPublicDraft

Authored by sidkmenon on Feb 9 2021, 5:47 PM.

Details

Reviewers
None
Summary

Listen/Notify skeleton for MySQL, as well as schema changes + BK checks to ensure future MySQL compatability

Note also that the listen/notify logic is not finished yet; a cursor seems to be the best way to go about the polling logic but having trouble finding the correct info in SQLAlchemy documentation.

Still TODO: cursor vs. query modification in SQL query, alembic migrations stuff, as well as testing & perf testing

Depends on https://dagster.phacility.com/D5710

Test Plan

N/A yet (work in progress)

Diff Detail

Repository
R1 dagster
Branch
mysql-backend (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

python_modules/libraries/dagster-mysql/dagster_mysql/event_log/event_log.py
287–303

This is the area that remains as the primary TODO - basically how I can keep a cursor alive between queries (or whether that's a sane thing to do at all). TBD - will update this diff as I make more progress.

alangenfeld added inline comments.
python_modules/libraries/dagster-mysql/dagster_mysql/event_log/event_log.py
287–303
sidkmenon marked an inline comment as done.
sidkmenon added inline comments.
python_modules/libraries/dagster-mysql/dagster_mysql/event_log/event_log.py
287–303

Thanks Alex! That was very helpful, I got the listen/notify tests passing. I am currently getting an RFC diff(s) ready with these changes.