Page MenuHomePhabricator

Configurable whitespace display in config editor
ClosedPublic

Authored by max on Jul 16 2019, 10:08 PM.

Details

Reviewers
natekupp
bengotow
Group Reviewers
Restricted Project
Commits
R1:d108c0b7f64b: Configurable whitespace display in config editor
Summary
Test Plan

Manual due to jsdom limitations

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Jul 16 2019, 10:08 PM
max edited the summary of this revision. (Show Details)Jul 16 2019, 10:10 PM
max edited the summary of this revision. (Show Details)
max updated this revision to Diff 2981.Jul 17 2019, 5:47 PM

Snapshots

max updated this revision to Diff 3035.Jul 18 2019, 4:52 PM

Rebase

bengotow accepted this revision.Jul 18 2019, 7:36 PM

Looks great! Nice to have this as an option!

js_modules/dagit/src/execute/PipelineExecutionContainer.tsx
41–42

I'm not 100% sure, but I think this is an autogenerated import from VSCode - it gets a little confused by @blueprintjs and we could probably merge this into the @blueprintjs/core import above. (ALIGN_RIGHT should be available there too.)

js_modules/dagit/src/index.tsx
21

Thanks for upgrading this!

This revision is now accepted and ready to land.Jul 18 2019, 7:36 PM
max marked an inline comment as done.Jul 18 2019, 8:30 PM
max added inline comments.
js_modules/dagit/src/execute/PipelineExecutionContainer.tsx
41–42

yep, this is unused also

max updated this revision to Diff 3043.Jul 18 2019, 8:30 PM
max marked an inline comment as done.

Nits

This revision was landed with ongoing or failed builds.Jul 18 2019, 8:34 PM
This revision was automatically updated to reflect the committed changes.