Remove RepositoryLocation.create_from_handle
ClosedPublic
Actions

Authored by dgibson on Feb 8 2021, 9:20 PM.

Details

Reviewers

johann
max
sashank
alangenfeld

Commits

R1:2fcbb0f9e040: Remove RepositoryLocation.create_from_handle

Summary

Similar to https://dagster.phacility.com/D6351, make it easier to add new repository locations without any centralized factories/maps.

Test Plan

Integration

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dgibson created this revision.Feb 8 2021, 9:20 PM

black

Harbormaster failed remote builds in B25446: Diff 31040!Feb 8 2021, 9:36 PM

Harbormaster completed remote builds in B25450: Diff 31044.Feb 8 2021, 9:46 PM

dgibson requested review of this revision.Feb 8 2021, 9:46 PM

defer to @sashank

sashank accepted this revision.Feb 9 2021, 5:46 PM

This revision is now accepted and ready to land.Feb 9 2021, 5:46 PM

Closed by commit R1:2fcbb0f9e040: Remove RepositoryLocation.create_from_handle (authored by dgibson). · Explain WhyFeb 9 2021, 7:29 PM

This revision was automatically updated to reflect the committed changes.

dgibson added a commit: R1:2fcbb0f9e040: Remove RepositoryLocation.create_from_handle.

Revision Contents
Changeset List

Path

Size

integration_tests/

test_suites/

k8s-integration-test-suite/

test_scheduler.py

7 lines

python_modules/

dagster-graphql/

dagster_graphql/

implementation/

context.py

8 lines

dagster_graphql_tests/

graphql/

setup.py

3 lines

test_dagster_environment.py

7 lines

dagster-test/

dagster_test/

dagster_core_docker_buildkite/

__init__.py

16 lines

test_project/

__init__.py

9 lines

dagster/

cli/

workspace/

cli_target.py

2 lines

core/

host_representation/

handle.py

23 lines

repository_location.py

18 lines

telemetry.py

3 lines

scheduler/

scheduler.py

3 lines

sensor.py

4 lines

utils/

external.py

8 lines

dagster_tests/

api_tests/

utils.py

3 lines

cli_tests/

workspace_tests/

multi_location/

test_multi_location_workspace.py

17 lines

core_tests/

test_pipeline_execution.py

3 lines

daemon_tests/

integration_tests/

conftest.py

3 lines

scheduler_tests/

test_scheduler_run.py

3 lines

test_sensor_run.py

7 lines

libraries/

dagster-cron/

dagster_cron_tests/

test_cron_scheduler.py

7 lines

Diff 31117

View Options

integration_tests/test_suites/k8s-integration-test-suite/test_scheduler.py

View Options

python_modules/dagster-graphql/dagster_graphql/implementation/context.py

View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/setup.py

View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_dagster_environment.py

View Options

python_modules/dagster-test/dagster_test/dagster_core_docker_buildkite/init.py

View Options

python_modules/dagster-test/dagster_test/test_project/init.py

View Options

python_modules/dagster/dagster/cli/workspace/cli_target.py

View Options

python_modules/dagster/dagster/core/host_representation/handle.py

View Options

python_modules/dagster/dagster/core/host_representation/repository_location.py

View Options

python_modules/dagster/dagster/core/telemetry.py

View Options

python_modules/dagster/dagster/scheduler/scheduler.py

View Options

python_modules/dagster/dagster/scheduler/sensor.py

View Options

python_modules/dagster/dagster/utils/external.py

View Options

python_modules/dagster/dagster_tests/api_tests/utils.py

View Options

python_modules/dagster/dagster_tests/cli_tests/workspace_tests/multi_location/test_multi_location_workspace.py

View Options

python_modules/dagster/dagster_tests/core_tests/test_pipeline_execution.py

View Options

python_modules/dagster/dagster_tests/daemon_tests/integration_tests/conftest.py

View Options

python_modules/dagster/dagster_tests/scheduler_tests/test_scheduler_run.py

View Options

python_modules/dagster/dagster_tests/scheduler_tests/test_sensor_run.py

View Options

python_modules/libraries/dagster-cron/dagster_cron_tests/test_cron_scheduler.py

Remove RepositoryLocation.create_from_handleClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31117

integration_tests/test_suites/k8s-integration-test-suite/test_scheduler.py

python_modules/dagster-graphql/dagster_graphql/implementation/context.py

python_modules/dagster-graphql/dagster_graphql_tests/graphql/setup.py

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_dagster_environment.py

python_modules/dagster-test/dagster_test/dagster_core_docker_buildkite/__init__.py

python_modules/dagster-test/dagster_test/test_project/__init__.py

python_modules/dagster/dagster/cli/workspace/cli_target.py

python_modules/dagster/dagster/core/host_representation/handle.py

python_modules/dagster/dagster/core/host_representation/repository_location.py

python_modules/dagster/dagster/core/telemetry.py

python_modules/dagster/dagster/scheduler/scheduler.py

python_modules/dagster/dagster/scheduler/sensor.py

python_modules/dagster/dagster/utils/external.py

python_modules/dagster/dagster_tests/api_tests/utils.py

python_modules/dagster/dagster_tests/cli_tests/workspace_tests/multi_location/test_multi_location_workspace.py

python_modules/dagster/dagster_tests/core_tests/test_pipeline_execution.py

python_modules/dagster/dagster_tests/daemon_tests/integration_tests/conftest.py

python_modules/dagster/dagster_tests/scheduler_tests/test_scheduler_run.py

python_modules/dagster/dagster_tests/scheduler_tests/test_sensor_run.py

python_modules/libraries/dagster-cron/dagster_cron_tests/test_cron_scheduler.py

Remove RepositoryLocation.create_from_handle
ClosedPublic
Actions

Revision Contents
Changeset List

python_modules/dagster-test/dagster_test/dagster_core_docker_buildkite/init.py

python_modules/dagster-test/dagster_test/test_project/init.py