Page MenuHomeElementl

Remove RepositoryLcoationHandle.create_from_repository_location_origin
ClosedPublic

Authored by dgibson on Feb 8 2021, 6:51 PM.

Details

Summary

This method makes it annoying to create new repository location types, particularly those that exist in other modules (which we would like to do now). Remove the method and replace it with a method on the origin class itself.

Test Plan

Integration

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 8 2021, 7:09 PM
Harbormaster failed remote builds in B25418: Diff 31006!
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 8 2021, 7:31 PM
Harbormaster failed remote builds in B25419: Diff 31007!

forgot to actually remove the method

seems fine by me, but would like @sashank to weigh in since he has been messing around here

This is definitely much cleaner. +1

This revision is now accepted and ready to land.Feb 9 2021, 5:09 PM