Page MenuHomeElementl

[dagit] Top-level pages for Schedules, Sensors
ClosedPublic

Authored by dish on Feb 5 2021, 5:05 PM.

Details

Summary

Create AllSchedulesRoot and AllSensorsRoot, reusing display code from the existing Instance tabs. When the nav changes are launched, we can remove those tabs from that page and refactor this a bit.

Test Plan

Enable simple nav, click on "Schedules" and "Sensors". Verify proper rendering and behavior. Navigate to individual schedules and sensors, verify that the nav items are appropriately highlighted.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish created this revision.

Rebase

dish requested review of this revision.Feb 5 2021, 5:12 PM

looks good - can you make sure the test plan includes unloadable schedules/sensors as well? easiest way to test is to turn one on and then change the repository name while it's still on.

This revision is now accepted and ready to land.Feb 8 2021, 3:38 PM

Rebase, regenerate types, double-check unloadables.

Unloadable schedules/sensors:

Screen Shot 2021-02-08 at 1.36.03 PM.png (864×1 px, 164 KB)

Screen Shot 2021-02-08 at 1.36.29 PM.png (754×1 px, 148 KB)

This revision was automatically updated to reflect the committed changes.