Page MenuHomeElementl

Repair pointer-events with Group margins
ClosedPublic

Authored by dish on Feb 5 2021, 2:33 PM.

Details

Summary

I ran into an issue with Group yesterday. When the negative margin of a nested Group overlaps interactive contents of its container Group, those contents cannot be clicked.

We need to set pointer-events accordingly. The wrapper of the Group should have none, and the children should be set back to auto. This allows the mouse to reach the underlying interactive contents while keeping the children interactive as normal.

I created a storybook story to demonstrate.

Test Plan

View "Pointer events test" story, verify that rendering and behavior are correct.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish created this revision.

Remove LeftNavSimple change, will diff it separately.

dish requested review of this revision.Feb 5 2021, 2:43 PM
This revision is now accepted and ready to land.Feb 5 2021, 4:36 PM
This revision was automatically updated to reflect the committed changes.