Page MenuHomeElementl

Generates a new repository skeleton.
ClosedPublic

Authored by bob on Feb 3 2021, 10:55 PM.

Details

Summary

When invoking the dagster new-repo CLI, a new repository skeleton is generated in the filesystem.

Depends on D6289

Test Plan

buildkite

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 3 2021, 11:08 PM
Harbormaster failed remote builds in B25258: Diff 30786!
  • Fixes import line spacing in test files.
  • Fix PyLint syntax errors with .tmpl file extension.
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 4 2021, 9:52 PM
Harbormaster failed remote builds in B25311: Diff 30861!
  • Changes Mode multiline string to Python comment.
  • Fixes import line spacing.
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 4 2021, 10:26 PM
Harbormaster failed remote builds in B25315: Diff 30866!
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 4 2021, 10:54 PM
Harbormaster failed remote builds in B25320: Diff 30874!
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 8 2021, 4:33 PM
Harbormaster failed remote builds in B25397: Diff 30983!
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 8 2021, 5:06 PM
Harbormaster failed remote builds in B25400: Diff 30986!

Adds Jinja2 dependency to setup.py.

python_modules/dagster/dagster/generate/new_repo/README.md
21

nit: they would need to install the python version before being able to create a virtualenv

34

I'd prefer that we define these requirements in a package https://packaging.python.org/tutorials/packaging-projects/#configuring-metadata

python_modules/dagster/dagster/generate/new_repo/new_repo/solids/hello.py
5

Include OutputDefinitions here so that functionality is exposed?

Use setup.py instead of requirements.txt, and updates README.md.

bob marked 2 inline comments as done and an inline comment as not done.Feb 9 2021, 8:57 PM
bob added inline comments.
python_modules/dagster/dagster/generate/new_repo/new_repo/solids/hello.py
5

I'm on the side of leaving it out, although it's tricky to decide which Dagster functionality to expose for the repository skeleton, especially since things like OutputDefintion is optional

This revision is now accepted and ready to land.Feb 10 2021, 6:07 PM
This revision was automatically updated to reflect the committed changes.