Page MenuHomeElementl

GH issue 3051 (Flower configuration - expose env vars)
ClosedPublic

Authored by catherinewu on Feb 3 2021, 7:02 AM.

Details

Summary
Test Plan

integration

we spin up flower in the one of the integration tests

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 3 2021, 7:15 AM
Harbormaster failed remote builds in B25221: Diff 30743!
catherinewu added a reviewer: nate.
catherinewu edited the summary of this revision. (Show Details)
catherinewu retitled this revision from GH issue 3051 to GH issue 3051 (Flower configuration - expose env vars).

should flower and the celery workers have different envs? or should this be shared?

This revision is now accepted and ready to land.Feb 4 2021, 11:32 PM

sent a snippet of user's code over Slack. yes, the flower env is different from the celery env in their case (also I think being maximally flexible for stuff like flower is preferable, so that we don't get in users' way)