Page MenuHomeElementl

GH issue 3609 (Expose labels field in celery config)
ClosedPublic

Authored by catherinewu on Feb 3 2021, 6:59 AM.

Diff Detail

Repository
R1 dagster
Branch
3609
Lint
Lint Errors
Unit
No Test Coverage

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 3 2021, 8:16 PM
Harbormaster failed remote builds in B25246: Diff 30772!
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 11 2021, 3:10 AM
Harbormaster failed remote builds in B25595: Diff 31237!
Harbormaster failed remote builds in B25596: Diff 31238!
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 11 2021, 3:44 AM
Harbormaster failed remote builds in B25598: Diff 31240!
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 11 2021, 4:06 AM
Harbormaster failed remote builds in B25600: Diff 31242!
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 11 2021, 4:26 AM
Harbormaster failed remote builds in B25601: Diff 31243!
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 11 2021, 4:47 AM
Harbormaster failed remote builds in B25602: Diff 31244!

cool, looks good to me. see one comment on testing; also, are there any other places we should expose the ability to add labels while you're at it?

helm/dagster/values.yaml
396

should this include explanatory text / comment above also? at least to explain the expected schema of this field?

integration_tests/python_modules/dagster-k8s-test-infra/dagster_k8s_test_infra/helm.py
358

is there some way we can confirm these labels are applied correctly?

This revision is now accepted and ready to land.Feb 11 2021, 6:05 AM

the changes after the "accept" review were only to add the tests in helm.py that check that the label is correctly applied to the deployment