Details
Details
integration
Diff Detail
Diff Detail
- Repository
- R1 dagster
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
There are a very large number of changes, so older changes are hidden. Show Older Changes
Comment Actions
cool, looks good to me. see one comment on testing; also, are there any other places we should expose the ability to add labels while you're at it?
helm/dagster/values.yaml | ||
---|---|---|
396 | should this include explanatory text / comment above also? at least to explain the expected schema of this field? | |
integration_tests/python_modules/dagster-k8s-test-infra/dagster_k8s_test_infra/helm.py | ||
358 | is there some way we can confirm these labels are applied correctly? |
Comment Actions
the changes after the "accept" review were only to add the tests in helm.py that check that the label is correctly applied to the deployment