Page MenuHomeElementl
Differential D6279

GH issue 3609 (Expose labels field in celery config)
ClosedPublic
Actions

Authored by catherinewu on Feb 3 2021, 6:59 AM.

Details

Reviewers
• nate
rexledesma
Commits
R1:88907f9473fb: GH issue 3609 (Expose labels field in celery config)
Summary

https://github.com/dagster-io/dagster/issues/3609

Test Plan

integration

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
catherinewu edited the summary of this revision. (Show Details)Feb 3 2021, 7:45 PM
catherinewu updated this revision to Diff 30772.Feb 3 2021, 7:59 PM

up

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 3 2021, 8:16 PM
Harbormaster failed remote builds in B25246: Diff 30772!
catherinewu updated this revision to Diff 31236.Feb 11 2021, 2:41 AM

up

catherinewu updated this revision to Diff 31237.Feb 11 2021, 2:52 AM

up

catherinewu updated this revision to Diff 31238.Feb 11 2021, 2:53 AM

up

Harbormaster failed remote builds in B25594: Diff 31236!Feb 11 2021, 3:00 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 11 2021, 3:10 AM
Harbormaster failed remote builds in B25595: Diff 31237!
Harbormaster failed remote builds in B25596: Diff 31238!
catherinewu updated this revision to Diff 31239.Feb 11 2021, 3:14 AM

up

catherinewu updated this revision to Diff 31240.Feb 11 2021, 3:28 AM

up

Harbormaster failed remote builds in B25597: Diff 31239!Feb 11 2021, 3:30 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 11 2021, 3:44 AM
Harbormaster failed remote builds in B25598: Diff 31240!
catherinewu updated this revision to Diff 31241.Feb 11 2021, 3:48 AM

up

catherinewu updated this revision to Diff 31242.Feb 11 2021, 3:52 AM

up

Harbormaster failed remote builds in B25599: Diff 31241!Feb 11 2021, 4:03 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 11 2021, 4:06 AM
Harbormaster failed remote builds in B25600: Diff 31242!
catherinewu updated this revision to Diff 31243.Feb 11 2021, 4:08 AM

up

catherinewu added reviewers: • nate, rexledesma.Feb 11 2021, 4:26 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 11 2021, 4:26 AM
Harbormaster failed remote builds in B25601: Diff 31243!
catherinewu updated this revision to Diff 31244.Feb 11 2021, 4:30 AM

up

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 11 2021, 4:47 AM
Harbormaster failed remote builds in B25602: Diff 31244!
catherinewu updated this revision to Diff 31245.Feb 11 2021, 4:52 AM

wtf

Harbormaster completed remote builds in B25603: Diff 31245.Feb 11 2021, 5:10 AM
catherinewu requested review of this revision.Feb 11 2021, 5:10 AM
catherinewu updated this revision to Diff 31246.Feb 11 2021, 6:03 AM

rebase

• nate accepted this revision.Feb 11 2021, 6:05 AM

cool, looks good to me. see one comment on testing; also, are there any other places we should expose the ability to add labels while you're at it?

helm/dagster/values.yaml
396

should this include explanatory text / comment above also? at least to explain the expected schema of this field?

integration_tests/python_modules/dagster-k8s-test-infra/dagster_k8s_test_infra/helm.py
358

is there some way we can confirm these labels are applied correctly?

This revision is now accepted and ready to land.Feb 11 2021, 6:05 AM
Harbormaster completed remote builds in B25604: Diff 31246.Feb 11 2021, 6:22 AM
catherinewu updated this revision to Diff 31248.Feb 11 2021, 6:34 AM

up

Harbormaster failed remote builds in B25606: Diff 31248!Feb 11 2021, 6:51 AM
catherinewu updated this revision to Diff 31250.Feb 11 2021, 7:00 AM

up

catherinewu updated this revision to Diff 31251.Feb 11 2021, 7:07 AM

up

catherinewu updated this revision to Diff 31252.Feb 11 2021, 7:08 AM

up

Harbormaster failed remote builds in B25608: Diff 31250!Feb 11 2021, 7:20 AM
Harbormaster completed remote builds in B25610: Diff 31252.Feb 11 2021, 7:26 AM
Harbormaster failed remote builds in B25609: Diff 31251!Feb 11 2021, 7:29 AM
catherinewu added a comment.Feb 11 2021, 7:30 AM

added tests

catherinewu updated this revision to Diff 31254.Feb 11 2021, 7:34 AM

up

Harbormaster failed remote builds in B25612: Diff 31254!Feb 11 2021, 7:52 AM
catherinewu updated this revision to Diff 31256.Feb 11 2021, 8:05 AM

up

catherinewu updated this revision to Diff 31257.Feb 11 2021, 8:07 AM

up

catherinewu updated this revision to Diff 31258.Feb 11 2021, 8:07 AM

up

catherinewu updated this revision to Diff 31259.Feb 11 2021, 8:20 AM

up

catherinewu updated this revision to Diff 31260.Feb 11 2021, 8:21 AM

up

catherinewu updated this revision to Diff 31261.Feb 11 2021, 8:23 AM

up

Harbormaster failed remote builds in B25614: Diff 31257!Feb 11 2021, 8:24 AM
Harbormaster failed remote builds in B25613: Diff 31256!
catherinewu updated this revision to Diff 31262.Feb 11 2021, 8:28 AM

up

catherinewu updated this revision to Diff 31263.Feb 11 2021, 8:29 AM

up

Harbormaster failed remote builds in B25615: Diff 31258!Feb 11 2021, 8:29 AM
catherinewu updated this revision to Diff 31264.Feb 11 2021, 8:29 AM

up

catherinewu updated this revision to Diff 31265.Feb 11 2021, 8:30 AM

up

Harbormaster failed remote builds in B25616: Diff 31259!Feb 11 2021, 8:37 AM
Harbormaster failed remote builds in B25617: Diff 31260!
Harbormaster failed remote builds in B25618: Diff 31261!
Harbormaster failed remote builds in B25619: Diff 31262!Feb 11 2021, 8:43 AM
Harbormaster failed remote builds in B25620: Diff 31263!
Harbormaster failed remote builds in B25621: Diff 31264!Feb 11 2021, 8:46 AM
Harbormaster completed remote builds in B25622: Diff 31265.Feb 11 2021, 8:49 AM
catherinewu added a comment.Feb 11 2021, 8:50 AM

the changes after the "accept" review were only to add the tests in helm.py that check that the label is correctly applied to the deployment

Closed by commit R1:88907f9473fb: GH issue 3609 (Expose labels field in celery config) (authored by catherinewu). · Explain WhyFeb 11 2021, 8:51 AM
This revision was automatically updated to reflect the committed changes.
catherinewu added a commit: R1:88907f9473fb: GH issue 3609 (Expose labels field in celery config).

Revision Contents
Changeset List

PathSize
helm/
dagster/
templates/
3 lines
17 lines
4 lines
integration_tests/
python_modules/
dagster-k8s-test-infra/
dagster_k8s_test_infra/
16 lines
python_modules/
automation/
automation/
helm/
schema/
subschema/
9 lines
1 line

Diff 31266

View Options

helm/dagster/templates/deployment-celery-queues.yaml

Loading...
View Options

helm/dagster/values.schema.json

Loading...
View Options

helm/dagster/values.yaml

Loading...
View Options

integration_tests/python_modules/dagster-k8s-test-infra/dagster_k8s_test_infra/helm.py

Loading...
View Options

python_modules/automation/automation/helm/schema/subschema/kubernetes.py

Loading...
View Options

python_modules/automation/automation/helm/schema/subschema/run_launcher.py

Loading...