Page MenuHomeElementl

[dagit] Add flag to enable new left nav
ClosedPublic

Authored by dish on Feb 2 2021, 7:29 PM.

Details

Summary

Add a flag to /settings that enables the exploratory left nav. Additionally:

  • Left nav
    • Create a nav item config to define the items, "active" route matches, etc.
    • Style changes
  • Search
    • Bootstrapping query for loading up searchable results
    • Repair open/close behavior
    • Add keyboard shortcut
    • Repair navigation behavior
    • Style changes
Test Plan

View Dagit, navigate to /settings. Toggle the left nav flag, verify that the app reloads with changes.

Use search, verify that it works as intended.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

js_modules/dagit/src/ui/Page.tsx
4

I need to settle on a value here. The nav spacing affects whether this looks good or not. I promise I won't thrash it forever.

dish requested review of this revision.Feb 2 2021, 7:34 PM

Ahh this is exciting! Look forward to trying it in the app - the code looks great to me ๐Ÿ‘

This revision is now accepted and ready to land.Feb 2 2021, 9:23 PM
This revision was automatically updated to reflect the committed changes.