Page MenuHomeElementl

[dagit] Roots for Pipelines, Settings
ClosedPublic

Authored by dish on Feb 1 2021, 8:47 PM.

Details

Summary

Create root pages for /workspace/pipelines and /settings, which are intended as top-level navigation items.

  • /workspace/pipelines will show a flattened list of all pipelines in the loaded workspace. It's a simple table to start with, and we can decide which columns are best suited for it.
  • /settings consolidates /flags and timezone settings, and gives us a place to add more user-specific settings in the future.
Test Plan

Navigate to these routes in dagit, verify success.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish requested review of this revision.Feb 1 2021, 8:56 PM

Looks good to me!

js_modules/dagit/src/app/SettingsRoot.tsx
22

May as well throw a [flags] dep on this I think!

js_modules/dagit/src/workspace/AllPipelinesRoot.tsx
65

I can't quite tell but we may want to make sure that this doesn't show "No Pipelines" while data is loading and only when it's actually loaded + empty.

This revision is now accepted and ready to land.Feb 1 2021, 10:01 PM
js_modules/dagit/src/workspace/AllPipelinesRoot.tsx
65

Yeah, I'm going to need to go through and clean all of this up before exposing it in the app. It's on my todo list.

Move setFeatureFlags side effect into state setter function.

Felt dirty to have the effect in the state setter, moved it back out.

This revision was automatically updated to reflect the committed changes.