Page MenuHomeElementl

[dagit] Time components
ClosedPublic

Authored by dish on Feb 1 2021, 8:45 PM.

Details

Summary

A handful of changes related to Time components.

  • Break apart TimeComponents into more specific parts, since most of its pieces don't need to be all in the same place.
  • Create TimezoneSelect, used by DarkTimezonePicker, which can be used in a forthcoming Settings page
Test Plan

Verify that all time-related components are rendering and behaving properly in Dagit.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish requested review of this revision.Feb 1 2021, 8:53 PM

Looks good to me! I'm surprised timestampToString is used outside the time folder since it's not user-settings-aware, but we can audit that later!

This revision is now accepted and ready to land.Feb 1 2021, 10:02 PM
This revision was automatically updated to reflect the committed changes.