Page MenuHomeElementl
Differential D6214

fix bad args for schedule job state
ClosedPublic
Actions

Authored by • prha on Jan 29 2021, 6:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Aug 14, 9:23 AM
Unknown Object (File)
Sat, Aug 13, 4:29 PM
Unknown Object (File)
Sat, Aug 13, 12:04 AM
Unknown Object (File)
Tue, Aug 2, 12:10 PM
Unknown Object (File)
Sun, Jul 31, 5:16 AM
Unknown Object (File)
Mon, Jul 25, 1:09 PM
Unknown Object (File)
Sat, Jul 23, 7:20 AM
Unknown Object (File)
Sat, Jul 23, 5:11 AM
View All 28 Files
Subscribers
None

Details

Reviewers
• catherinewu
Commits
R1:d4c33e93db7c: fix bad args for schedule job state
Summary

When the schedule job state is empty, we require an instance argument. Provide the instance
for the default job state for all job types.

Fixes https://github.com/dagster-io/dagster/issues/3626

Test Plan

Loaded blank state for schedule

Diff Detail

Repository
R1 dagster
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

• prha created this revision.Jan 29 2021, 6:16 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 29 2021, 6:35 PM
Harbormaster failed remote builds in B25025: Diff 30493!
• prha updated this revision to Diff 30502.Jan 29 2021, 7:02 PM

add bk tests

Harbormaster completed remote builds in B25033: Diff 30502.Jan 29 2021, 7:23 PM
• prha requested review of this revision.Jan 29 2021, 7:24 PM
• catherinewu accepted this revision.Jan 29 2021, 9:09 PM

Macro pooh_eating_honey:

This revision is now accepted and ready to land.Jan 29 2021, 9:09 PM
Closed by commit R1:d4c33e93db7c: fix bad args for schedule job state (authored by • prha). · Explain WhyJan 29 2021, 9:19 PM
This revision was automatically updated to reflect the committed changes.
• prha added a commit: R1:d4c33e93db7c: fix bad args for schedule job state.

Revision Contents
Changeset List

PathSize
python_modules/
dagster-graphql/
dagster_graphql/
implementation/
2 lines
schema/
4 lines
dagster_graphql_tests/
graphql/
snapshots/
19 lines
8 lines
dagster/
dagster/
cli/
2 lines
core/
host_representation/
2 lines

Diff 30502

View Options

python_modules/dagster-graphql/dagster_graphql/implementation/fetch_jobs.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql/schema/sensors.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_sensors.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_scheduler.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_sensors.py

Loading...
View Options

python_modules/dagster/dagster/cli/sensor.py

Loading...
View Options

python_modules/dagster/dagster/core/host_representation/external.py

Loading...