Page MenuHomeElementl

add dagster-azure back to dev_install
ClosedPublic

Authored by yuhan on Jan 29 2021, 3:48 AM.

Details

Summary
Test Plan

in fresh virtualenv

~/dev/dagster arcpatch-D6207
$ make dev_install

~/dev/dagster arcpatch-D6207
$ test-D6207 $ pip freeze | grep azure
azure-common==1.1.26
azure-core==1.10.0
azure-storage-blob==12.3.2
azure-storage-file-datalake==12.0.2
-e git+git@github.com:dagster-io/dagster.git@bd35c74ff476078799a55650d70fa5c28b43d373#egg=dagster_azure&subdirectory=python_modules/libraries/dagster-azure


~/dev/dagster/docs arcpatch-D6207
test-D6207 $ make buildnext && cd next && yarn && yarn dev

Screen Shot 2021-02-01 at 3.27.30 PM.png (3×2 px, 1 MB)

Diff Detail

Repository
R1 dagster
Branch
arcpatch-D6207
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

yuhan requested review of this revision.Jan 29 2021, 4:13 AM

hmm did you try this on a clean venv? last I tried it didn't work properly

This lgtm if Nate's concern is addressed

This revision is now accepted and ready to land.Jan 30 2021, 4:41 PM
This revision was automatically updated to reflect the committed changes.