Differential D6207

add dagster-azure back to dev_install
ClosedPublic
Actions

Authored by yuhan on Jan 29 2021, 3:48 AM.

Tags

None

Subscribers

None

Details

Reviewers

• sashank
• nate
sandyryza

Commits

R1:78af8685b254: add dagster-azure back to dev_install

Summary

https://github.com/dagster-io/dagster/issues/3573

https://github.com/dagster-io/dagster/pull/2483#issuecomment-635174157

Test Plan

in fresh virtualenv

~/dev/dagster arcpatch-D6207
$ make dev_install

~/dev/dagster arcpatch-D6207
$ test-D6207 $ pip freeze | grep azure
azure-common==1.1.26
azure-core==1.10.0
azure-storage-blob==12.3.2
azure-storage-file-datalake==12.0.2
-e git+git@github.com:dagster-io/dagster.git@bd35c74ff476078799a55650d70fa5c28b43d373#egg=dagster_azure&subdirectory=python_modules/libraries/dagster-azure


~/dev/dagster/docs arcpatch-D6207
test-D6207 $ make buildnext && cd next && yarn && yarn dev

Screen Shot 2021-02-01 at 3.27.30 PM.png (3×2 px, 1 MB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yuhan created this revision.Jan 29 2021, 3:48 AM

up

Harbormaster completed remote builds in B25009: Diff 30472.Jan 29 2021, 4:06 AM

Harbormaster completed remote builds in B25011: Diff 30474.Jan 29 2021, 4:13 AM

yuhan requested review of this revision.Jan 29 2021, 4:13 AM

hmm did you try this on a clean venv? last I tried it didn't work properly

This lgtm if Nate's concern is addressed

This revision is now accepted and ready to land.Jan 30 2021, 4:41 PM

yuhan edited the test plan for this revision. (Show Details)Feb 1 2021, 11:28 PM

up

Harbormaster completed remote builds in B25122: Diff 30613.Feb 1 2021, 11:51 PM

• nate accepted this revision.Feb 2 2021, 12:06 AM

Closed by commit R1:78af8685b254: add dagster-azure back to dev_install (authored by yuhan). · Explain WhyFeb 2 2021, 12:34 AM

This revision was automatically updated to reflect the committed changes.

yuhan added a commit: R1:78af8685b254: add dagster-azure back to dev_install.

Revision Contents
Changeset List

Path

Size

scripts/

install_dev_python_modules.py

6 lines

Diff 30620

scripts/install_dev_python_modules.py

Loading...