Page MenuHomeElementl

[dagit] Standardize and slow down Spinner
ClosedPublic

Authored by dish on Jan 27 2021, 9:05 PM.

Details

Summary

We've got a zillion different Spinner sizes all over Dagit. This consolidates them into a handful of specific sizes matched to various purposes around the app.

Also, working on a couple other loading-state tasks recently, I came to feel like the speed of the Spinner is a little stressful. This reduces the rotation speed from 0.5s to 0.8s, which feels a little less urgent.

Additionally, I put a lint rule in place to prevent people from importing the Blueprint Spinner directly. Instead, they should use the Dagit-specific Spinner.

Test Plan

View spinners all over Dagit where I can find them, verify that they look and behave correctly.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 27 2021, 9:13 PM
Harbormaster failed remote builds in B24927: Diff 30368!
dish requested review of this revision.Jan 27 2021, 9:44 PM

This looks good to me! Big fan of standardizing these, even if it makes things less pixel-perfect in a button or two. ๐Ÿ™Œ

js_modules/dagit/.eslintrc.js
51

Oh this is cool, I didn't realize you could specify error messages in here!

js_modules/dagit/src/execute/LaunchButton.tsx
231

Seems like this might be a visible change since it's no longer adjusting with the small param, but I'm guessing it looks fine. ๐Ÿ’„

This revision is now accepted and ready to land.Feb 1 2021, 4:04 PM
js_modules/dagit/src/execute/LaunchButton.tsx
231

I'll double-check that this ends up okay. It's a pretty small difference in pixels, so hopefully it's not bad.

js_modules/dagit/src/execute/LaunchButton.tsx
231

I'll double-check that this ends up okay. It's a pretty small difference in pixels, so hopefully it's not bad.

231

I think it looks all right.

image.png (100ร—408 px, 8 KB)

This revision was automatically updated to reflect the committed changes.