Page MenuHomeElementl

[dagit] RFC: Launch runs in the same tab
ClosedPublic

Authored by dish on Jan 27 2021, 5:06 PM.

Details

Summary

From user feedback in Slack:

Is there any way to prevent dagit from opening new windows every-time that I execute a pipeline? While testing it's a bit annoying having to close windows. Also, the behaviour is not consistent anyway, if you use the "re-execute All (*)" in the same window it doesn't open a new window...

It looks like this behavior is intentional, but I figured I'd put up a diff to discuss making the behavior consistent by always opening the launched run in the same tab.

Test Plan

Launch runs, verify that they are launched in the current tab.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish requested review of this revision.Jan 27 2021, 5:12 PM

Hmm this was definitely intentional but I don't quite remember the context around it. I went back and found the original diff where that was added (https://github.com/dagster-io/dagster/commit/02b1d07b6b00407c9533d4d718efc6195620961a#diff-0788ce9e6243e61675f971ee6022361b57a9d1a0b32fcff11036acf8583e22fb) but there's not much of an explanation and it's almost two years old. I'd say we merge this and give it a spin, and if there's interest in opening things in separate windows we could potentially allow cmd-clicking on the buttons, etc to send openInNewWindow: true.

This revision is now accepted and ready to land.Feb 1 2021, 3:53 PM
This revision was automatically updated to reflect the committed changes.