Page MenuHomePhabricator

add root query for job state, put nextTick field on job state
ClosedPublic

Authored by prha on Tue, Jan 26, 11:20 PM.

Details

Summary

This enables a more generic way of getting the next tick for a job state

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

prha requested review of this revision.Tue, Jan 26, 11:41 PM
dgibson added inline comments.
python_modules/dagster-graphql/dagster_graphql/implementation/fetch_jobs.py
46–48

should this pattern be like a get_job_state_or_default method (or be in get_job_state), seems easy to forget

python_modules/dagster-graphql/dagster_graphql/implementation/fetch_sensors.py
15

This should probably sue DEFAULT_DAEMON_INTERVAL_SECONDS, already defined elsewhere? So that if we change it or make it configurable it auto-updates here?

python_modules/dagster-graphql/dagster_graphql/schema/errors.py
642

You have used the forbidden word here

python_modules/dagster-graphql/dagster_graphql/schema/roots.py
834

here again

This revision is now accepted and ready to land.Wed, Jan 27, 4:49 PM
python_modules/dagster-graphql/dagster_graphql/implementation/fetch_sensors.py
15

I think I did that in the original diff, and you said we should change it?

https://dagster.phacility.com/D5605#inline-36576

I can just define a new const and import it here...