Page MenuHomePhabricator

[4/4] Remove ExecutionPlan.environment_config
AbandonedPublic

Authored by dgibson on Jan 25 2021, 5:05 PM.

Details

Reviewers
alangenfeld
Summary

To make it so that an ExecutionPlan can be created without being able to load a PipelineDefinition, replace the small number of methods on ExecutionPlan that require one with a method parameter rather than assuming it exists as state on the class.

Test Plan

Integration

Diff Detail

Repository
R1 dagster
Branch
rmpipelinedefartifacts3
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 25 2021, 5:24 PM
Harbormaster failed remote builds in B24809: Diff 30209!
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 25 2021, 6:08 PM
Harbormaster failed remote builds in B24814: Diff 30216!
dgibson retitled this revision from Remove ExecutionPlan.environment_config to [4/4] Remove ExecutionPlan.environment_config.Jan 25 2021, 6:39 PM
This revision is now accepted and ready to land.Tue, Jan 26, 10:12 PM

putting on ice for now