Page MenuHomePhabricator

add future tick, run requests to schema
ClosedPublic

Authored by prha on Jan 23 2021, 1:22 AM.

Details

Summary

This diff exposes runRequests in the graphql schema, so that the client can query for the
tags / config for future ticks.

Depends on D6123

Also fixes a bug when fetching schedules as external jobs.

Test Plan

bk, added future tick graphql test

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 23 2021, 1:33 AM
Harbormaster failed remote builds in B24739: Diff 30131!
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 23 2021, 1:50 AM
Harbormaster failed remote builds in B24742: Diff 30134!
prha requested review of this revision.Jan 23 2021, 3:22 AM
dgibson requested changes to this revision.Jan 25 2021, 6:06 PM

looks good, What about SkipReason too though? Particularly given https://github.com/dagster-io/dagster/commit/baf6b21e6aeda63c2042dd79109de5471d4db3a9 which makes it more likely for one to appear?

This revision now requires changes to proceed.Jan 25 2021, 6:06 PM
dgibson added inline comments.
python_modules/dagster-graphql/dagster_graphql/schema/jobs.py
98

not sure you need the pendulum.instance, believe a pendulum datetime always comes out of that function

99–104

this can also return a ExternalScheduleExecutionErrorData - we should probably display the PythonError in dagit when that happens? Would be useful for debugging

python_modules/dagster-graphql/dagster_graphql/schema/schedules/schedules.py
89

tick_timestamp?

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_scheduler.py
304

would be great to include a scheduleexecutiondataerror test case here as well (like bad_env_fn_schedule in test_scheduler_run)

This revision is now accepted and ready to land.Jan 26 2021, 2:06 AM

update, add top-level evaluation result field, add error test case

This revision was automatically updated to reflect the committed changes.