Page MenuHomePhabricator

Add tests for automation
ClosedPublic

Authored by nate on Jul 13 2019, 1:50 AM.

Details

Summary

This gets automation test coverage from 0% to > 90%

Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nate created this revision.Jul 13 2019, 1:50 AM
nate updated this revision to Diff 2868.Jul 13 2019, 1:53 AM

add to buildkite

nate updated this revision to Diff 2871.Jul 13 2019, 3:25 PM

up tox

nate updated this revision to Diff 2873.Jul 13 2019, 6:47 PM

snapshot tests for dataproc parsing

nate updated this revision to Diff 2875.Jul 13 2019, 7:07 PM

bytes

nate edited the summary of this revision. (Show Details)Jul 13 2019, 11:11 PM
nate added reviewers: max, schrockn.
alangenfeld accepted this revision.Jul 15 2019, 4:01 PM
alangenfeld added inline comments.
.buildkite/pipeline.py
161

do we really care these scripts run in every python?

python_modules/automation/automation_tests/files/spark_confs.md
1 ↗(On Diff #2879)

this could go in a __snapshots__ directory (causing them to be hidden in phab)

This revision is now accepted and ready to land.Jul 15 2019, 4:01 PM
nate updated this revision to Diff 2880.Jul 15 2019, 4:19 PM
nate edited the summary of this revision. (Show Details)

comments

This revision was automatically updated to reflect the committed changes.