Page MenuHomeElementl

yield a SkipReason when a partitioned schedule can't find its partition
ClosedPublic

Authored by dgibson on Jan 22 2021, 4:12 AM.

Details

Summary

Right now if you create your own schedule from a partition set and mess up the timezones (or get the offset from execution time to partition set wrong) your schedule will skip silently with no useful information. This diff tries to make that marginally better by at least explaining that the problem is that your partition selector didn't return anything. (Would be nice to give more information about what partition it tried to find, but the partition_selector API doesn't currently allow that)

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

prha added inline comments.
python_modules/dagster/dagster/core/definitions/partition.py
197–201

Makes sense that we have the user_code_error_boundary here... Does the error get buried under two layers? I know that we wrap the execution_fn with one (in grpc/impl.py)...

This revision is now accepted and ready to land.Jan 22 2021, 5:02 PM