Page MenuHomePhabricator

[10/n]Make StepOutput user-code-free
AbandonedPublic

Authored by dgibson on Jan 21 2021, 11:09 PM.

Details

Reviewers
alangenfeld
Summary

Believe this finishes the chain and makes it possible to load an ExecutionStep without loading any user code, just snapshots.

Test Plan

BK

Diff Detail

Repository
R1 dagster
Branch
rmpipelinedef10
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

dgibson retitled this revision from Make StepOutput user-code-free to [10/n]Make StepOutput user-code-free.Jan 21 2021, 11:12 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 22 2021, 12:16 AM
Harbormaster failed remote builds in B24674: Diff 30049!
alangenfeld added inline comments.
python_modules/dagster/dagster/core/events/__init__.py
492–503

should only happen in user code - context should have real defs

python_modules/dagster/dagster/core/execution/plan/execute_step.py
75–82

should be able to load the output_def like below - this code is user land only

python_modules/dagster/dagster/core/snap/solid.py
76

output_def has is_dynamic also

327–331

I think you will need to know is_dynamic in the host process at some point but not the other two

This revision now requires changes to proceed.Jan 22 2021, 10:33 PM