Paths

Table of Contentst

Differential D6095

[10/n]Make StepOutput user-code-free
AbandonedPublic
Actions

Authored by dgibson on Jan 21 2021, 11:09 PM.

Tags

None

Subscribers

None

Details

Reviewers

Summary

Believe this finishes the chain and makes it possible to load an ExecutionStep without loading any user code, just snapshots.

Test Plan

BK

Diff Detail

Repository

Branch

rmpipelinedef10

Lint

Lint OK

Unit

No Unit Test Coverage

Event Timeline

dgibson created this revision.Jan 21 2021, 11:09 PM

dgibson retitled this revision from Make StepOutput user-code-free to [10/n]Make StepOutput user-code-free.Jan 21 2021, 11:12 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 22 2021, 12:16 AM

Harbormaster failed remote builds in B24674: Diff 30049!

up

up

Harbormaster failed remote builds in B24696: Diff 30074!Jan 22 2021, 6:35 AM

Harbormaster completed remote builds in B24699: Diff 30077.Jan 22 2021, 6:41 AM

dgibson requested review of this revision.Jan 22 2021, 6:41 AM

dgibson added a reviewer: alangenfeld.Jan 22 2021, 3:38 PM

alangenfeld requested changes to this revision.Jan 22 2021, 10:33 PM

alangenfeld added inline comments.

python_modules/dagster/dagster/core/events/__init__.py
492–503	should only happen in user code - context should have real defs
python_modules/dagster/dagster/core/execution/plan/execute_step.py
75–82	should be able to load the output_def like below - this code is user land only
python_modules/dagster/dagster/core/snap/solid.py
76	output_def has `is_dynamic` also
327–331	I think you will need to know `is_dynamic` in the host process at some point but not the other two

This revision now requires changes to proceed.Jan 22 2021, 10:33 PM

squashed into https://dagster.phacility.com/D6133

Revision Contents
Changeset List

Path

Size

python_modules/

dagster-graphql/

dagster_graphql_tests/

graphql/

snapshots/

snap_test_all_snapshot_ids.py

snap_test_pipeline_snapshot.py

dagster/

dagster/

core/

events/

2 lines

execution/

context/

18 lines

plan/

43 lines

execute_step.py

16 lines

13 lines

12 lines

3 lines

resources_init.py

16 lines

snap/

execution_plan_snapshot.py

2 lines

27 lines

dagster_tests/

core_tests/

snap_tests/

snapshots/

snap_test_active_data.py

snap_test_execution_plan.py

snap_test_pipeline_snap.py

Diff 30077

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_all_snapshot_ids.py

Loading...

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_pipeline_snapshot.py

Loading...

python_modules/dagster/dagster/core/events/init.py

Loading...

python_modules/dagster/dagster/core/execution/context/system.py

Loading...

python_modules/dagster/dagster/core/execution/plan/compute.py

Loading...

python_modules/dagster/dagster/core/execution/plan/execute_step.py

Loading...

python_modules/dagster/dagster/core/execution/plan/outputs.py

Loading...

python_modules/dagster/dagster/core/execution/plan/plan.py

Loading...

python_modules/dagster/dagster/core/execution/plan/step.py

Loading...

python_modules/dagster/dagster/core/execution/resources_init.py

Loading...

python_modules/dagster/dagster/core/snap/execution_plan_snapshot.py

Loading...

python_modules/dagster/dagster/core/snap/solid.py

Loading...

python_modules/dagster/dagster_tests/core_tests/snap_tests/snapshots/snap_test_active_data.py

Loading...

python_modules/dagster/dagster_tests/core_tests/snap_tests/snapshots/snap_test_execution_plan.py

Loading...

python_modules/dagster/dagster_tests/core_tests/snap_tests/snapshots/snap_test_pipeline_snap.py

Loading...