BK
Details
Details
Diff Detail
Diff Detail
- Repository
- R1 dagster
- Branch
- rmpipelinedef9
- Lint
Lint OK - Unit
No Unit Test Coverage
Event Timeline
| python_modules/dagster/dagster/core/execution/plan/inputs.py | ||
|---|---|---|
| 85–88 | nit: might be cleaner to just hoist compute_version calc up off this class | |
| 92 | nit: think just solid_handle is clearer (to me) | |
| python_modules/dagster/dagster/core/execution/plan/plan.py | ||
| 251–328 | same as prev diff - would like to see this get cleanedup in stack before stack lands | |
| python_modules/dagster/dagster/core/snap/dagster_types.py | ||
| 29–98 | shouldn't need these in the snapshot - I could see required_resource_keys maybe being something we would want to display in dagit / know in host, but loader_required_resource_keys seems very dubious | |
| python_modules/dagster/dagster/core/snap/solid.py | ||
| 296 | also not needed - at least for what you are trying to accomplish - we should grab the real defs for resource init path | |