[8/n] Make StepInput.dagster_type a snapshot instead (no user code)
AbandonedPublic
Actions

Authored by dgibson on Jan 21 2021, 9:48 PM.

Details

Reviewers

alangenfeld

Summary

As title.

Test Plan

Diff Detail

Repository

R1 dagster

Branch

rmpipelinedef8

Lint

Lint OK

Unit

No Unit Test Coverage

Event Timeline

dgibson created this revision.Jan 21 2021, 9:48 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 21 2021, 10:06 PM

Harbormaster failed remote builds in B24668: Diff 30040!

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 21 2021, 10:54 PM

Harbormaster failed remote builds in B24671: Diff 30046!

dgibson retitled this revision from Make StepInput.dagster_type a snapshot instead (no user code) to [8/n] Make StepInput.dagster_type a snapshot instead (no user code).Jan 21 2021, 11:11 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 21 2021, 11:27 PM

Harbormaster failed remote builds in B24672: Diff 30047!

Harbormaster completed remote builds in B24692: Diff 30070.Jan 22 2021, 4:38 AM

dgibson requested review of this revision.Jan 22 2021, 4:38 AM

dgibson added a reviewer: alangenfeld.Jan 22 2021, 3:38 PM

alangenfeld requested changes to this revision.Jan 22 2021, 10:15 PM

alangenfeld added inline comments.

python_modules/dagster/dagster/core/execution/resources_init.py
306	do the look up via grabbing the InputDefinition via the `solid_def`
python_modules/dagster/dagster/core/snap/dagster_types.py
86–88	we shouldn't need to know the resource keys for host mode since we won't be booting any resources up