Page MenuHomePhabricator

update instance info string functions to properly yaml-format output
ClosedPublic

Authored by owen on Jan 21 2021, 8:04 PM.

Details

Summary

Changed the flow of info string generation to first create a dictionary (nested as necessary), then convert that dictionary to a yaml string, rather than manually building the yaml string from scratch.

Test Plan

navigating to localhost:3000/instance/config displays properly-formatted yaml info

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 21 2021, 8:27 PM
Harbormaster failed remote builds in B24660: Diff 30029!

fixed typo for component str info generation

owen requested review of this revision.Jan 21 2021, 9:53 PM
prha added inline comments.
python_modules/dagster/dagster/serdes/__init__.py
312–318

we don't need this anymore, do we?

This revision is now accepted and ready to land.Jan 21 2021, 9:54 PM
python_modules/dagster/dagster/serdes/__init__.py
312–318

I guess it isn't being used anywhere other than the function I touched, so yeah I can delete this