Page MenuHomePhabricator
Differential D6086

[5/n] Wait to determine step compute_fn until you're actually in step execution
AbandonedPublic
Actions

Authored by dgibson on Jan 21 2021, 5:46 PM.

Details

Reviewers
alangenfeld
Summary

Part N of many of making ExecutionPlan create-able within a host process.

Test Plan

BK

Diff Detail

Repository
R1 dagster
Branch
rmpipelinedef5
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

dgibson created this revision.Jan 21 2021, 5:46 PM
Harbormaster completed remote builds in B24642: Diff 30005.Jan 21 2021, 6:04 PM
dgibson requested review of this revision.Jan 21 2021, 6:04 PM
dgibson retitled this revision from Wait to determine step compute_fn until you're actually in step execution to [5/n] Wait to determine step compute_fn until you're actually in step execution.Jan 22 2021, 3:37 PM
alangenfeld accepted this revision.Jan 22 2021, 4:46 PM
alangenfeld added inline comments.
python_modules/dagster/dagster/core/execution/plan/execute_step.py
444–453

think we can drop the gen and None check since this func is always a generator

This revision is now accepted and ready to land.Jan 22 2021, 4:46 PM
dgibson abandoned this revision.Jan 24 2021, 11:28 PM

squashed into https://dagster.phacility.com/D6133

Revision Contents
Changeset List

PathSize
python_modules/
dagster/
dagster/
core/
execution/
plan/
5 lines
10 lines
12 lines

Diff 30005

View Options

python_modules/dagster/dagster/core/execution/plan/compute.py

Loading...
View Options

python_modules/dagster/dagster/core/execution/plan/execute_step.py

Loading...
View Options

python_modules/dagster/dagster/core/execution/plan/step.py

Loading...